feat: add better linting targets and CI #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerslaton
force-pushed
the
linter
branch
3 times, most recently
from
5fef25e to
d9dc69d
Compare
|
Added in a temp commit to simulate what CI runs for each of these would look like.
|
tylerslaton
requested review from
ibuildthecloud,
thedadams and
ryanhopperlowe
thedadams
reviewed
Oct 17, 2024
Makefile
Outdated
Comment on lines
30
to
31
| go fmt ./... && \ | ||
| go vet ./... |
There was a problem hiding this comment.
This should probably be the golangci-lint that we have used in other places.
ryanhopperlowe
approved these changes
Oct 17, 2024
|
UI side looks good! |
Signed-off-by: tylerslaton <[email protected]>
|
I removed the API linting for now since we want to use golangci lint instead. When we do that it'll be a larger undertaking. |
thedadams
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in a couple of new make targets:
make lint-api- Lints the APImake lint-admin- Lints the admin UImake lint- The previous two combinedAlong with this I've split out the CI to run the
apilint on Go changes andadminlint on changes to the admin UI. This helps linting locally and saves some time on PRs so everything is not linted together.